Skip to content

Return default alphafold version when parsing or request for XML fails #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davereinhart merged 2 commits into from
Feb 27, 2026
Merged

Return default alphafold version when parsing or request for XML fails #670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f866325
Return default alphafold version when parsing or request for XML fails
davereinhart Feb 27, 2026
87a790e
Remove unused import
davereinhart Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/mavedb/routers/alphafold.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
from fastapi import APIRouter, HTTPException
import httpx
import xml.etree.ElementTree as ET
import re
import xml.etree.ElementTree as ET

import httpx
from fastapi import APIRouter

from mavedb.lib.logging.logged_route import LoggedRoute

Expand All @@ -14,15 +15,18 @@
route_class=LoggedRoute,
)


@router.get("/alphafold-files/version")
async def proxy_alphafold_index():
"""
Proxy the AlphaFold files index (XML document).
"""
DEFAULT_RESPONSE = {"version": "v6"}

async with httpx.AsyncClient(follow_redirects=True, timeout=30) as client:
resp = await client.get(ALPHAFOLD_BASE, headers={"Accept": "application/xml"})
if resp.status_code != 200:
raise HTTPException(status_code=resp.status_code, detail="Upstream error fetching AlphaFold files index")
return DEFAULT_RESPONSE

# parse XML response
try:
Expand All @@ -42,9 +46,9 @@ async def proxy_alphafold_index():

match = re.search(r"model_(v\d+)\.pdb$", next_marker, re.IGNORECASE)
if not match:
raise HTTPException(status_code=500, detail="Malformed AlphaFold PDB ID in XML")
return DEFAULT_RESPONSE
version = match.group(1)
return {"version": version.lower()}

except ET.ParseError as e:
raise HTTPException(status_code=502, detail=f"Failed to parse upstream XML: {e}")
except Exception:
return DEFAULT_RESPONSE