fix: correct false-positive URN search tests#673
Open
bencap wants to merge 1 commit intorelease-2026.1.2from
Open
fix: correct false-positive URN search tests#673bencap wants to merge 1 commit intorelease-2026.1.2from
bencap wants to merge 1 commit intorelease-2026.1.2from
Conversation
The 7 URN search tests sent {"urn": ...} in the search payload, but
ScoreSetsSearch has no `urn` field — Pydantic silently dropped it.
Tests passed coincidentally because each created only one score set,
making unfiltered results match the expected count.
Fix by using {"text": ...} (matching actual frontend behavior) and
adding a second decoy score set to each test so the filter is actually
exercised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 7 URN search tests sent {"urn": ...} in the search payload, but ScoreSetsSearch has no
urnfield — Pydantic silently dropped it. Tests passed coincidentally because each created only one score set, making unfiltered results match the expected count.Fix by using {"text": ...} (matching actual frontend behavior) and adding a second decoy score set to each test so the filter is actually exercised.