Merged
Conversation
🦋 Changeset detectedLatest commit: 823436a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-sun-venus
force-pushed
the
feat/swap-repay
branch
from
b8cfd4e to
b4bc256
Compare
david-sun-venus
force-pushed
the
feat/swap-repay
branch
from
b4bc256 to
967ebfc
Compare
Contributor
david-sun-venus
force-pushed
the
feat/swap-repay
branch
from
967ebfc to
f5a721f
Compare
david-sun-venus
force-pushed
the
feat/swap-repay
branch
from
f5a721f to
13a4cad
Compare
david-sun-venus
force-pushed
the
feat/swap-repay
branch
from
be685c1 to
f736539
Compare
therealemjy
force-pushed
the
feat/swap-repay
branch
from
77aa16c to
d0b1177
Compare
Member
|
@greptile |
Greptile SummaryThis PR upgrades swap and repay functionality to use the new SwapRouterV2 contracts, simplifying the API from 9 function variants to 4. However, it introduces a critical bug in the wrap/unwrap native token feature. Key Changes
Critical IssueThe wrap/unwrap native token feature is broken. The Impact
Confidence Score: 1/5
Important Files Changed
Last reviewed commit: d811401 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+110
to
+121
| // DEV ONLY | ||
| const ts = (Math.floor(Date.now() / 1000) + 100).toString(16); | ||
| await fetch('https://virtual.binance.eu.rpc.tenderly.co/a18c3519-9972-46ff-9d01-5b2f83a992e2', { | ||
| method: 'POST', | ||
| headers: { 'Content-Type': 'application/json' }, | ||
| body: JSON.stringify({ | ||
| id: 1, | ||
| jsonrpc: '2.0', | ||
| method: 'tenderly_setNextBlockTimestamp', | ||
| params: [`0x${ts}`], | ||
| }), | ||
| }); |
There was a problem hiding this comment.
DEV ONLY code must be removed before merging to production. This introduces a hardcoded Tenderly RPC call that manipulates block timestamps.
Suggested change
| // DEV ONLY | |
| const ts = (Math.floor(Date.now() / 1000) + 100).toString(16); | |
| await fetch('https://virtual.binance.eu.rpc.tenderly.co/a18c3519-9972-46ff-9d01-5b2f83a992e2', { | |
| method: 'POST', | |
| headers: { 'Content-Type': 'application/json' }, | |
| body: JSON.stringify({ | |
| id: 1, | |
| jsonrpc: '2.0', | |
| method: 'tenderly_setNextBlockTimestamp', | |
| params: [`0x${ts}`], | |
| }), | |
| }); | |
| if (!gasless) { | |
| // Estimate gas limit |
Comment on lines
+8
to
+11
| iconSrc: iconSrcs.bsc, | ||
| explorerUrl: 'https://bscscan.com', | ||
| // explorerUrl: 'https://bscscan.com', | ||
| explorerUrl: | ||
| 'https://dashboard.tenderly.co/venus-labs/project/testnet/43b649f5-b426-44f5-8052-c7836bdb67f5', |
There was a problem hiding this comment.
Production BSCScan explorer URL commented out in favor of Tenderly dashboard. Revert to production configuration before merging.
Suggested change
| iconSrc: iconSrcs.bsc, | |
| explorerUrl: 'https://bscscan.com', | |
| // explorerUrl: 'https://bscscan.com', | |
| explorerUrl: | |
| 'https://dashboard.tenderly.co/venus-labs/project/testnet/43b649f5-b426-44f5-8052-c7836bdb67f5', | |
| explorerUrl: 'https://bscscan.com', |
Comment on lines
+13
to
+16
| [ChainId.BSC_MAINNET]: [ | ||
| `https://bsc-mainnet.nodereal.io/v1/${nodeRealApiKey}`, | ||
| `https://bnb-mainnet.g.alchemy.com/v2/${alchemyApiKey}`, | ||
| // `https://bsc-mainnet.nodereal.io/v1/${nodeRealApiKey}`, | ||
| // `https://bnb-mainnet.g.alchemy.com/v2/${alchemyApiKey}`, | ||
| 'https://virtual.binance.eu.rpc.tenderly.co/0acab753-b3d0-4fa6-91f8-8ca1578a00e3', |
There was a problem hiding this comment.
Production RPC URLs (NodeReal, Alchemy) replaced with Tenderly virtual testnet. Must revert to production endpoints before merging.
Suggested change
| [ChainId.BSC_MAINNET]: [ | |
| `https://bsc-mainnet.nodereal.io/v1/${nodeRealApiKey}`, | |
| `https://bnb-mainnet.g.alchemy.com/v2/${alchemyApiKey}`, | |
| // `https://bsc-mainnet.nodereal.io/v1/${nodeRealApiKey}`, | |
| // `https://bnb-mainnet.g.alchemy.com/v2/${alchemyApiKey}`, | |
| 'https://virtual.binance.eu.rpc.tenderly.co/0acab753-b3d0-4fa6-91f8-8ca1578a00e3', | |
| `https://bsc-mainnet.nodereal.io/v1/${nodeRealApiKey}`, | |
| `https://bnb-mainnet.g.alchemy.com/v2/${alchemyApiKey}`, |
therealemjy
force-pushed
the
feat/swap-repay
branch
from
d0b1177 to
31300d4
Compare
… to dropdown select in swap
Member
|
@greptile |
Member
|
@greptile |
Member
|
@greptile |
therealemjy
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket(s)
VPD-571
Changes