feat: add workspace support for packages check licenses#1444
Closed
realmeylisdev wants to merge 7 commits intoVeryGoodOpenSource:mainfrom
Closed
feat: add workspace support for packages check licenses#1444realmeylisdev wants to merge 7 commits intoVeryGoodOpenSource:mainfrom
realmeylisdev wants to merge 7 commits intoVeryGoodOpenSource:mainfrom
Conversation
When a pubspec.yaml declares a workspace property, the command now recursively collects dependencies from all workspace members and checks their licenses using the root pubspec.lock. This enables license checking in monorepo projects that use Dart's pub workspace feature. Closes #1273
Contributor
Author
|
Hey @marcossevilla , would you mind reviewing this please? |
Contributor
Author
|
Hey @marcossevilla let's review this as well |
|
@realmeylisdev @marcossevilla was there a reason why this got removed from v1.0.0 ? We use the cli tool for checking licenses and wanted to utilize this change. |
Member
|
hi @samitsv, we de-prioritized this because we didn't have time to review it and had a deadline for v1. we could review it now but @realmeylisdev seems to have deleted the head repository so the PR closed. |
|
is there any chance the branch could be brought back up @realmeylisdev ? |
Contributor
Author
|
Branch has been restored @samitsv |
4 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds workspace support to the
packages check licensescommand, enabling license checking in monorepo projects that use Dart's pub workspace feature.Closes #1273
Changes
New Files
lib/src/pubspec/pubspec.dart- Pubspec parser for detecting workspace configurationstest/src/pubspec/pubspec_test.dart- 19 tests for the Pubspec parserModified Files
lib/src/commands/packages/commands/check/commands/licenses.dart- Added workspace detection and dependency collectiontest/src/commands/packages/commands/check/commands/licenses_test.dart- Added 3 workspace support testsHow It Works
pubspec.yamlcontains aworkspaceproperty, it's detected as a workspace rootpubspec.yamlfilespackages/*are supported (Dart 3.11+)Test plan