fix: conditionally generate platform jobs in flutter_plugin main workflow#1541
Open
realmeylisdev wants to merge 1 commit intoVeryGoodOpenSource:mainfrom
Open
fix: conditionally generate platform jobs in flutter_plugin main workflow#1541realmeylisdev wants to merge 1 commit intoVeryGoodOpenSource:mainfrom
realmeylisdev wants to merge 1 commit intoVeryGoodOpenSource:mainfrom
Conversation
…flow Regenerate the very_good_flutter_plugin bundle from the fixed template source that wraps each platform E2E test job with Mason conditionals. Only selected platforms are now included in the generated main workflow. Closes VeryGoodOpenSource#469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
very_good_flutter_pluginbundle with platform-conditional E2E test jobs in the main workflow.github/workflows/{project_name}.yamlCloses #469
Context
When creating a Flutter plugin with specific platforms (e.g.,
--platforms android,ios), thepre_gen.darthook correctly sets boolean variables (android: true,ios: true,web: false, etc.). Platform-specific workflow files (e.g.,{project_name}_android.yaml) were already correctly wrapped in file-level Mason conditionals. However, the main workflow included E2E test jobs for all 6 platforms unconditionally.The fix wraps each platform job with
{{#platform}}...{{/platform}}, following the same pattern already used for{{#publishable}}pana{{/publishable}}in the same file.Upstream template fix: VeryGoodOpenSource/very_good_templates#460
Test plan
--platforms android,iosand verify the main workflow only containsandroidandiosE2E jobs