Skip to content

fix/update existing tests #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnsonChin1009 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix/update existing tests #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4cf6bb
feat: updated tests to reflect latest acpJob.ts
JohnsonChin1009 Mar 2, 2026
0778aa1
feat: updated tests to reflect latest acpClient.ts
JohnsonChin1009 Mar 3, 2026
689378d
chore: deprecate snake case for top_k test
JohnsonChin1009 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions test/integration/acpClient.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,16 +218,15 @@ describe("AcpClient Integration Testing", () => {
}
}, 30000);

it("should respect top_k parameter", async () => {
it("should respect topK parameter", async () => {
const keyword = "agent";
const topK = 2;
const k = 3;
const options = {
topK: topK,
topK: k,
};

const result = await acpClient.browseAgents(keyword, options);

expect(result.length).toBeLessThanOrEqual(topK);
expect(result.length).toBeLessThanOrEqual(k);
}, 30000);

it("should handle search with sort options", async () => {
Expand All @@ -246,7 +245,7 @@ describe("AcpClient Integration Testing", () => {
it("should handle search with graduation status filter", async () => {
const keyword = "agent";
const options = {
top_k: 5,
topK: 5,
graduationStatus: AcpGraduationStatus.GRADUATED,
};

Expand All @@ -259,7 +258,7 @@ describe("AcpClient Integration Testing", () => {
it("should handle search with online status filter", async () => {
const keyword = "agent";
const options = {
top_k: 5,
topK: 5,
onlineStatus: AcpOnlineStatus.ONLINE,
};

Expand Down
Loading
Loading