fix: assign random cache folders to prevent errors with multiple brow…#419
Open
saul-l wants to merge 2 commits intoVoltstro-Studios:masterfrom
Open
fix: assign random cache folders to prevent errors with multiple brow…#419saul-l wants to merge 2 commits intoVoltstro-Studios:masterfrom
saul-l wants to merge 2 commits intoVoltstro-Studios:masterfrom
Conversation
Random cache path is now deleted OnDestroy
Author
|
Wasn't sure if cache folders are automatically deleted on all platforms (likely not), so I added automatic deletion to OnDestroy(). I think this should be fine default behavior, but could be further improved by making it optional. |
Voltstro
requested changes
Jan 1, 2026
Member
Voltstro
left a comment
Voltstro
left a comment
There was a problem hiding this comment.
While I am happy to take in a feature where UWB does this, I don't want to break current behavior where UWB will use <AdditionalFilesDirectory>/UWBCache. This should all be done via a boolean (E.G: randomCachePath), and also should be done in the WebBrowserClient class rather then BaseUwbClientManager class.
Also I'm sorry that it has taken me until now to review this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple browser instances didn't work before. This assigns random cache folder for each browser client and seems to work fine.