Conversation
slw546
requested review from
Christos-Hadjinikolis,
arturk-vortexa,
deaglancrew,
joloppo and
matteo-pallini
as code owners
slw546
added
echoes/effort: S
slw546
force-pushed
the
rnd_11428
branch
3 times, most recently
from
45c0537 to
5ce57ec
Compare
pytables does not currently support numpy 2.0 for python<3.10. As we support python 3.9 we must now pin the numpy version. This does not occur on python 3.8 as numpy 2 is not available, whilst python>3.10 can use numpy 2.0 compatible pytables
Christos-Hadjinikolis
force-pushed
the
rnd_11428
branch
from
10cb147 to
8bcfd01
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Allows writing dataframes to PF by appending to the table
Key Changes
Impact: Pins numpy to <2.0 !!
This is necessary due to pytables. They support numpy 2 as of pytables 3.10.x. However, they have not released this version for python < 3.10, despite numpy2 being released for python 3.9. Pandas is requiring numpy >= 1.2, so we either pin pandas or pin numpy. Pinning numpy feels slightly less restrictive as pandas can still be satisfied to a range of versions including those supporting numpy2
N.b. that doesn't occur on py3.8 since numpy 2 was not released there, so it's purely a py3.9 problem...
Checklist
The following won't apply in all cases - mark
N/Anext to point if not needed.