Add 1.4.5 support and custom item splits#12
Open
CactusDuper wants to merge 7 commits intoVoxelse:mainfrom
Open
Add 1.4.5 support and custom item splits#12CactusDuper wants to merge 7 commits intoVoxelse:mainfrom
CactusDuper wants to merge 7 commits intoVoxelse:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions 1.4.5.0-1.4.5.5 are supported with this PR.
1.4.5.0 and later use a different function to check for crimson:
Terraria.Recipe.GetRequiredTileStyle. All versions prior to 1.4.5.0 still use the previous function:Terraria.WorldGen.AddShadowOrbChanged how items are added to the autosplitter. Any item can now be selected. Verified that this change did not impact older versions of the game. Old item splits should be auto converted to the new format.
I'm not familiar with C# UI so I'm unsure if
ItemSelectorFormwas done properly.Please let me know if anything needs to be changed!