Make menu layer override when showing popup optional

[AKArien]

Currently, when the menu widget pops out it’s popover, it sets the panel layer to GTK_LAYER_SHELL_LAYER_OVERLAY. I am pretty sure it doesn’t really have a place here, as a user desiring this would just set the panel itself to overlay, and as someone who has it in the TOP layer, i just find it aggravating when it pops up.

[trigg]

Denied, this is a feature as otherwise the menu pops up but never manages to present itself to the user

[trigg]

For reference, with it Always in Top it will never show up over a fullscreen video or game. with it Always in Overlay it never hides behind fullscreen video or games.

With this feature it only appears when requested

[AKArien]

Well, this is precisely my problem. No objections for an option, i’d assume ?

[trigg]

By all means, make it an option. When you press to open the menu you expect it not to appear?

[AKArien]

yup, because i expect it to be hidden behind the window that is fullscreened. which, now that i think about it, this being my instinctual response probably means it’s better as is ;)

[AKArien]

Drafted because current version is Not Great™, the menu actually still « pops up » and can still somewhat interfere, in that it can eat the key that is used to pop up the menu.

I would think that this behaviour would be best relocated to the WayfireMenuButton, but i’m unsure of what to use to determine wether or not to try to pop up. Maybe an ipc call ? If any ideas pop to your mind, i’d be glad to hear

[trigg]

The keypress is eaten by the 'Wayfire shell protocol' plugin of wayfire, regardless of if it is used by the menu or not.

You'd need to disable this plugin whenever you have a fullscreen app as a way to avoid this.