Skip to content

panel: volume: Fix broken popdown on left click after scroll to change volume #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soreau merged 1 commit into from
Feb 27, 2026
Merged

panel: volume: Fix broken popdown on left click after scroll to change volume #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/panel/widgets/volume.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,26 @@ void WayfireVolume::init(Gtk::Box *container)
"default-sink-changed", G_CALLBACK(default_sink_changed), this);
gvc_mixer_control_open(gvc_control);

/* Ensure left click reliably toggles scale popover */
auto left_click_gesture = Gtk::GestureClick::create();
left_click_gesture->set_button(1);
left_click_gesture->signal_pressed().connect([=] (int count, double x, double y)
{
left_click_gesture->set_state(Gtk::EventSequenceState::CLAIMED);
});
left_click_gesture->signal_released().connect([=] (int count, double x, double y)
{
if (popover->is_visible())
{
popover->popdown();
popover_timeout.disconnect();
} else
{
popover->popup();
check_set_popover_timeout();
}
});

/* Middle click toggle mute */
auto middle_click_gesture = Gtk::GestureClick::create();
auto long_press = Gtk::GestureLongPress::create();
Expand All @@ -231,6 +251,7 @@ void WayfireVolume::init(Gtk::Box *container)
gvc_mixer_stream_push_volume(gvc_stream);
}));
button->add_controller(long_press);
button->add_controller(left_click_gesture);
button->add_controller(middle_click_gesture);

/* Setup layout */
Expand Down