Skip to content

Catch exceptions in test wrapper #8503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sertonix wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Draft

Catch exceptions in test wrapper #8503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,12 @@ def test_suite(name, func):
@functools.wraps(func)
def wrapper(*args, **kwargs):
assert not (shared.options.abort_on_first_failure and shared.num_failures)
result = func(*args, **kwargs)
try:
result = func(*args, **kwargs)
except Exception as e:
print(e)
shared.num_failures += 1
result = None
Copy link
Member

@kripken kripken Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is different in wasm2js tests that they need this but others do not?

If the others use fail_with_error (which is where num_failures seems to be handled), perhaps it should use it, rather than this change?

Copy link
Contributor Author

@sertonix sertonix Mar 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are probably better ways to do this but I don't know what they would be. Maybe it would be better I create an issue for this instead?

This is the stacktrace I get without this change:

Traceback (most recent call last):
  File "/builds/sertonix/aports/community/binaryen/src/binaryen-version_128/check.py", line 488, in <module>
    sys.exit(main())
             ^^^^^^
  File "/builds/sertonix/aports/community/binaryen/src/binaryen-version_128/check.py", line 471, in main
    TEST_SUITES[test]()
  File "/builds/sertonix/aports/community/binaryen/src/binaryen-version_128/check.py", line 422, in wrapper
    result = func(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^
  File "/builds/sertonix/aports/community/binaryen/src/binaryen-version_128/scripts/test/wasm2js.py", line 163, in test_wasm2js
    test_wasm2js_output()
  File "/builds/sertonix/aports/community/binaryen/src/binaryen-version_128/scripts/test/wasm2js.py", line 126, in test_wasm2js_output
    out = support.run_command(cmd, expected_err='', err_ignore='ExperimentalWarning')
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builds/sertonix/aports/community/binaryen/src/binaryen-version_128/scripts/test/support.py", line 154, in run_command
    raise Exception(f"run_command `{' '.join(cmd)}` failed ({code}) {err or ''}")
Exception: run_command `/usr/bin/node --experimental-modules --no-warnings --loader /builds/sertonix/aports/community/binaryen/src/binaryen-version_128/scripts/test/node-esm-loader.mjs a.2asm.asserts.mjs` failed (1) 
node:internal/modules/run_main:107
    triggerUncaughtException(
    ^
assertion failed on line 345
(Use `node --trace-uncaught ...` to show where the exception was thrown)
Node.js v24.14.0

Copy link
Member

@kripken kripken Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the stack trace, I think this might be a general issue with support.run_command. Things like shared.fail_if_not_contained work right, handling the number of errors etc., so I would guess the best fix here is in support.run_command - perhaps adding shared.run_command which wraps around it, calling fail_with_error if it errors. That would fix not only wasm2js but all others.

if shared.options.abort_on_first_failure and shared.num_failures:
raise Exception(f'test suite failed: {name}')
return result
Expand Down