Conversation
sbc100
changed the title
EXPORT_EXCEPTION_HANDLING_HELPERS
Member
Author
|
This is currently blocking the emscripten emsdk roller due to Is this the correct fix? The support code in binaryen seem to unconditionally depend on binaryen/src/js/binaryen.js-post.js Line 3281 in 132f7e8 |
Member
Author
|
Landing TBR to unblock the roller. |
Member
|
Yeah, unless it is compiling binaryen with |
aheejin
added a commit
to aheejin/emscripten
that referenced
this pull request
Mar 21, 2026
…ation Like WebAssembly/binaryen#8507, there can be people who use this methods at `-O1` or above. This adds more explanation of the workaround in ChangeeLog, site docs, and the deprecation message. You don't strictly need `decrementExceptionRefcount` to use `getExceptionMessage`, but you need it if you care about asan, because exceptions thrown in Wasm and caught in JS don't get freed unless you explicitly decrement the refcount.
aheejin
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Mar 21, 2026
…ation (#26517) Like WebAssembly/binaryen#8507, there can be people who use this methods at `-O1` or above. This adds more explanation of the workaround in ChangeeLog, site docs, and the deprecation message. You don't strictly need `decrementExceptionRefcount` to use `getExceptionMessage`, but you need it if you care about asan, because exceptions thrown in Wasm and caught in JS don't get freed unless you explicitly decrement the refcount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See emscripten-core/emscripten#26499