Skip to content

[spec] add missing rules for HANDLER#2063

Merged
rossberg merged 3 commits intoWebAssembly:mainfrom
zilinc:spec-main
Feb 3, 2026
Merged

[spec] add missing rules for HANDLER#2063
rossberg merged 3 commits intoWebAssembly:mainfrom
zilinc:spec-main

Conversation

@zilinc
Copy link
Copy Markdown
Contributor

@zilinc zilinc commented Jan 30, 2026

No description provided.

@zilinc zilinc changed the title [spec] add missing context rule for HANDLER [spec] add missing rules for HANDLER Jan 30, 2026
Copy link
Copy Markdown
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I just noticed another problem with these rules: they assume the frame is unchanged, which of course makes them incompatible with local.set.

While here, do you mind fixing this by adding the state's f component to each rule, with f' on the righthand-side?

@zilinc
Copy link
Copy Markdown
Contributor Author

zilinc commented Feb 3, 2026

Reordered the rules and squashed the commits.

@rossberg
Copy link
Copy Markdown
Member

rossberg commented Feb 3, 2026

Thanks! There are some merge conflicts with the test expectations. I think you need to merge main and rerun tests.

(Aside: No need to squash, that happens anyway when merging the PR. To the contrary, please never force-push to a branch under review, as that breaks some of GH's review functionality.)

@zilinc zilinc marked this pull request as draft February 3, 2026 14:19
@zilinc zilinc marked this pull request as ready for review February 3, 2026 15:51
@zilinc
Copy link
Copy Markdown
Contributor Author

zilinc commented Feb 3, 2026

Thanks! There are some merge conflicts with the test expectations. I think you need to merge main and rerun tests.

(Aside: No need to squash, that happens anyway when merging the PR. To the contrary, please never force-push to a branch under review, as that breaks some of GH's review functionality.)

Okay I've done that. Sorry about messing up the workflow. Hope this time it's the right way.

@rossberg
Copy link
Copy Markdown
Member

rossberg commented Feb 3, 2026

Thanks! No worries, it's a super common mistake, and unfortunately, Github does not offer any means for preventing it, despite popular request. In general, it's almost always better to use git merge instead of rebase.

@rossberg rossberg merged commit 1c9a04e into WebAssembly:main Feb 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants