Merged
Conversation
wasm.hh types (FuncType, GlobalType, etc.) are empty pimpl handles —
sizeof is 1. The actual allocated object is the concrete impl (e.g.
FuncTypeImpl, 40 bytes). Using `delete x` on the derived wrapper struct
triggered ASAN new-delete-type-mismatch because the sized operator delete
received sizeof(wasm_functype_t)=1 instead of sizeof(FuncTypeImpl)=40.
Fix: use destroyer{}(static_cast<Name*>(x)) which routes through
Name::destroy() -> delete impl(this), the correct cleanup path.
Re-enable `make c` in CI now that the memory management issue is fixed.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use goto-based cleanup to ensure engine/store/binary are always freed on all error paths. Also fix fclose missing before goto on fread failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Set experimental_wasm_typed_funcref flag in flags_init() so externref wasm modules compile correctly. Update hostref.wat to use typed ref.null syntax (ref.null extern) required by the typed funcref proposal, and regenerate hostref.wasm. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: