Conversation
Member
Author
|
The Bikeshed's support of SpecRef and "microphone" is flawed at the moment, so let's just land this with a plain text of "microphone". We have other (pre-exisiting) instances of "microphone" as well, so this is not a regression. Also the newest version of Bikeshed on Python 3.12 changed the build error log format, so we have to reproduce the expected-errs.txt file again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the recent failure log:
https://github.com/WebAudio/web-audio-api/actions/runs/19301435663/job/57588563539
Upgrading 3.12 might cause some unexpected changes, so we need to monitor the build carefully.
Preview | Diff