Skip to content

Specify adding an EventListener also opens MIDIInput ports#275

Merged
mjwilson-google merged 1 commit intoWebAudio:gh-pagesfrom
mjwilson-google:event-listener
Jan 7, 2025
Merged

Specify adding an EventListener also opens MIDIInput ports#275
mjwilson-google merged 1 commit intoWebAudio:gh-pagesfrom
mjwilson-google:event-listener

Conversation

@mjwilson-google
Copy link
Contributor

This is to fix #225

@mjwilson-google
Copy link
Contributor Author

Paul, your initial issue report talked about MIDIOuptut but I think the change should be about MIDIInput instead. Could you please review this, and help clarify if I've misunderstood?

Copy link
Member

@padenot padenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my mistake, this looks good, thanks!

@mjwilson-google mjwilson-google merged commit 6e85e43 into WebAudio:gh-pages Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event Handlers vs. Event Listener and implicit call to open()

2 participants