dotnet: move the Wasm compilation into the first run #268
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
eqrion
approved these changes
Jan 29, 2026
Contributor
eqrion
left a comment
eqrion
left a comment
There was a problem hiding this comment.
LGTM, I agree with this change. Thanks!
Contributor
Author
|
Thanks, perfect. I'll merge this to main in the UI and upload a cherry-pick to 3.0 in a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed yesterday, I think we should have all "interesting" or substantial parts of the workload inside the measurement window. So far, the dotnet Wasm compilation (as part of
this.dotnet.withModuleConfig) was not, since it happened inBenchmark.init().This PR moves it into the first iteration, as it should have been (and is for the other Wasm workloads).
CC @eqrion @kmiller68