Skip to content

Fix --test for d8 shell runner #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyeecheung wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Fix --test for d8 shell runner #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ const printHelp = cliParams.delete("help");
const dumpTestList = cliParams.delete("dumpTestList");

if (cliArgs.length) {
let tests = cliParams.has("test") ? cliParams.get("tests").split(",") : []
let tests = cliParams.has("test") ? cliParams.get("test").split(",") : []
Copy link
Contributor

@camillobruni camillobruni Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a shell test as well to https://github.com/WebKit/JetStream/blob/main/tests/run-shell.mjs so we don't accidentally regress this again?

tests = tests.concat(cliArgs);
cliParams.set("test", tests.join(","));
}
Expand Down
5 changes: 5 additions & 0 deletions utils/shell-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,8 @@ if (typeof performance == "undefined")

performance.mark ??= function(){};
performance.measure ??= function(){};

if (isD8) {
performance.mark = function(){};
Copy link
Contributor

@camillobruni camillobruni Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark and measure is supported in newer d8 versions (we do run CI tests so this does work). What d8 version were you using?

See https://crrev.com/c/6634602

Copy link
Author

@joyeecheung joyeecheung Mar 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using a main branch pulled yesterday (or at least I believe so) - now I am running it again from a different computer and this no longer seems needed after I fixed the typo 🤯 some what puzzled about what's going on, but I think this can be removed..

performance.measure = function(){};
}