Add CMAKE_CROSSCOMPILING_EMULATOR to ICU tool invocations#227
Merged
iangrunert merged 2 commits intomainfrom Feb 23, 2026
Merged
Add CMAKE_CROSSCOMPILING_EMULATOR to ICU tool invocations#227iangrunert merged 2 commits intomainfrom
iangrunert merged 2 commits intomainfrom
Conversation
Prepend ${CMAKE_CROSSCOMPILING_EMULATOR} to all COMMAND lines that
invoke ICU data-generation tools (genrb, icupkg, gencnval, etc.).
This allows cross-compilation without binfmt_misc by explicitly
running .exe tools through Wine. When CMAKE_CROSSCOMPILING_EMULATOR
is undefined (native Windows builds), CMake drops it from the
argument list -- no behavior change.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
foopoiuyt
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to get rid of the binfmt_misc requirement from the cross-compile, making it way easier to run inside a container.