Merged
Conversation
Currently, when the parser encounters an invalid keyword inside a function or a structure it gives an invalid function statement or invalid member definition error instead of stating that an invalid keyword was found. This was written as a response to the feature request of better error messages when loops are used inside structs but expands on it to include all possible invalid keywords
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the parser encounters an invalid keyword inside a function or a structure it gives an invalid function statement or invalid member definition error instead of stating that an invalid keyword was found.
This PR aims at detecting any keyword that is caught after all the valid ones have been parsed to give a more appropriate error message
This was written as a response to the feature request of better error messages when loops are used inside structs made in the ImHex issues #2687 but expands on it to include all possible invalid keywords.