Title Check: Avoid Deprecated warnings when there's no file contents.#482
Open
Title Check: Avoid Deprecated warnings when there's no file contents.#482
Conversation
Collaborator
|
I believe this closes #476 ? The PR did not solve the whole problem, I am seeing: |
Check that file_content is a string, both before and after the preg_replace.
Collaborator
|
Copilot changed it to Testing instructions:
|
Collaborator
|
There is an alternative PR that adds the is_string check to the if statement: https://github.com/WordPress/theme-check/pull/477/changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not 100% sure how this is happening, but seems like a quick win to avoid unnecessary processing and break early.