Playground PR review support for two-factor#836
Playground PR review support for two-factor#836masteradhoc wants to merge 4 commits intoWordPress:masterfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
georgestephanis
left a comment
There was a problem hiding this comment.
It feels like we can skip the build plugin zip workflow, and instead rely on the new git:directory
https://make.wordpress.org/playground/2025/12/19/action-required-github-proxy-com-shutdown/
https://wordpress.github.io/wordpress-playground/blueprints/steps/resources/#gitdirectoryreference
hat tip to @fellyph for posting about the update!
kasparsd
left a comment
There was a problem hiding this comment.
Noting that we have this Grunt task for generating the Blueprint URL:
Lines 50 to 56 in ab51db1
It appears that Blueprints support GitHub origin:
so we can skip the ZIP generation completely and let it pull the specific branch name. So maybe have a Grunt task that pulls the default blueprint.json and updates the installPlugin step to use the branch origin of the current pull request?
What?
Add a WordPress Playground preview button to pull requests.
Fixes #774
Why?
Makes it easier to test plugin changes without a local environment — reviewers can click a button directly from the PR to try the changes in a live Playground instance.
How?
Two new workflows:
Testing Instructions
Whats not testable yet: PR Playground Preview.
The reason is a GitHub limitation with workflow_run — workflows using that trigger must exist on the default branch to work. Since pr-playground-preview.yml only exists on this feature branch (not yet merged to master), GitHub ignores it.
Changelog Entry