Skip to content

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Feb 2, 2026

This file was added in #9014 but missing from r60516.

While reviewing another PR, I noticed Failed to load resource: net::ERR_FILE_NOT_FOUND errors in the qunit tests and investigated. It led me to this line which references a file that doesn't exist in the repo:

<script src="wp-admin/js/theme.js"></script>

See https://core.trac.wordpress.org/ticket/63126.

Trac ticket: https://core.trac.wordpress.org/ticket/64225


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

This file was added in WordPress#9014
but missing from r60516.

See https://core.trac.wordpress.org/ticket/63126.

Props abcd95.
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sirreal sirreal requested a review from joedolson February 2, 2026 11:02
@sirreal
Copy link
Member Author

sirreal commented Feb 2, 2026

Testing can confirm that there are no Failed to load resource: net::ERR_FILE_NOT_FOUND messages on CI:

https://github.com/WordPress/wordpress-develop/actions/runs/21587508566/job/62199177243?pr=10847

Trunk does have them:

Running "qunit:files" (qunit) task
Testing tests/qunit/compiled.html JQMIGRATE: Migrate is installed, version 3.4.1
Failed to load resource: net::ERR_FILE_NOT_FOUND
.....................................................................................................................................................................................................................OK
Testing tests/qunit/index.html JQMIGRATE: Migrate is installed with logging active, version 3.4.1
Failed to load resource: net::ERR_FILE_NOT_FOUND
.....................................................................................................................................................................................................................OK

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sirreal
Copy link
Member Author

sirreal commented Feb 2, 2026

I'm surprised this was not caught by quint and reported as an error:

https://qunitjs.com/api/extension/QUnit.onUncaughtException/

@mukeshpanchal27
Copy link
Member

I'm surprised this was not caught by quint and reported as an error:

https://qunitjs.com/api/extension/QUnit.onUncaughtException/

+1 Let's explore why it was not shown the error and commit this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants