-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Tests: Add theme keyboard navigation tests #10847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
This file was added in WordPress#9014 but missing from r60516. See https://core.trac.wordpress.org/ticket/63126. Props abcd95.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Testing can confirm that there are no https://github.com/WordPress/wordpress-develop/actions/runs/21587508566/job/62199177243?pr=10847 |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
I'm surprised this was not caught by quint and reported as an error: https://qunitjs.com/api/extension/QUnit.onUncaughtException/ |
+1 Let's explore why it was not shown the error and commit this one |
This file was added in #9014 but missing from r60516.
While reviewing another PR, I noticed
Failed to load resource: net::ERR_FILE_NOT_FOUNDerrors in the qunit tests and investigated. It led me to this line which references a file that doesn't exist in the repo:wordpress-develop/tests/qunit/index.html
Line 150 in f0aa4ec
See https://core.trac.wordpress.org/ticket/63126.
Trac ticket: https://core.trac.wordpress.org/ticket/64225
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.