Skip to content

Code Quality: Replace is_integer() with is_int() for consistency #11319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Soean wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Code Quality: Replace is_integer() with is_int() for consistency #11319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/wp-admin/includes/class-pclzip.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ function create($p_filelist)
$v_size--;

// ----- Look for first arg
if ((is_integer($v_arg_list[0])) && ($v_arg_list[0] > 77000)) {
if ((is_int($v_arg_list[0])) && ($v_arg_list[0] > 77000)) {

// ----- Parse the options
$v_result = $this->privParseOptions($v_arg_list, $v_size, $v_options,
Expand Down Expand Up @@ -479,7 +479,7 @@ function add($p_filelist)
$v_size--;

// ----- Look for first arg
if ((is_integer($v_arg_list[0])) && ($v_arg_list[0] > 77000)) {
if ((is_int($v_arg_list[0])) && ($v_arg_list[0] > 77000)) {

// ----- Parse the options
$v_result = $this->privParseOptions($v_arg_list, $v_size, $v_options,
Expand Down Expand Up @@ -732,7 +732,7 @@ function extract()
$v_arg_list = func_get_args();

// ----- Look for first arg
if ((is_integer($v_arg_list[0])) && ($v_arg_list[0] > 77000)) {
if ((is_int($v_arg_list[0])) && ($v_arg_list[0] > 77000)) {

// ----- Parse the options
$v_result = $this->privParseOptions($v_arg_list, $v_size, $v_options,
Expand Down Expand Up @@ -893,7 +893,7 @@ function extractByIndex($p_index)
$v_size--;

// ----- Look for first arg
if ((is_integer($v_arg_list[0])) && ($v_arg_list[0] > 77000)) {
if ((is_int($v_arg_list[0])) && ($v_arg_list[0] > 77000)) {

// ----- Parse the options
$v_result = $this->privParseOptions($v_arg_list, $v_size, $v_options,
Expand Down Expand Up @@ -1479,7 +1479,7 @@ function privParseOptions(&$p_options_list, $p_size, &$v_result_list, $v_request

// ----- Check the value
$v_value = $p_options_list[$i+1];
if ((!is_integer($v_value)) || ($v_value<0)) {
if ((!is_int($v_value)) || ($v_value<0)) {
PclZip::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Integer expected for option '".PclZipUtilOptionText($p_options_list[$i])."'");
return PclZip::errorCode();
}
Expand Down Expand Up @@ -1646,7 +1646,7 @@ function privParseOptions(&$p_options_list, $p_size, &$v_result_list, $v_request
// ----- Parse items
$v_work_list = explode(",", $p_options_list[$i+1]);
}
else if (is_integer($p_options_list[$i+1])) {
else if (is_int($p_options_list[$i+1])) {
$v_work_list[0] = $p_options_list[$i+1].'-'.$p_options_list[$i+1];
}
else if (is_array($p_options_list[$i+1])) {
Expand Down Expand Up @@ -1944,7 +1944,7 @@ function privFileDescrParseAtt(&$p_file_list, &$p_filedescr, $v_options, $v_requ
break;

case PCLZIP_ATT_FILE_MTIME :
if (!is_integer($v_value)) {
if (!is_int($v_value)) {
PclZip::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, "Invalid type ".gettype($v_value).". Integer expected for attribute '".PclZipUtilOptionText($v_key)."'");
return PclZip::errorCode();
}
Expand Down
2 changes: 1 addition & 1 deletion src/wp-includes/IXR/class-IXR-value.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function calculateType()
if ($this->data === true || $this->data === false) {
return 'boolean';
}
if (is_integer($this->data)) {
if (is_int($this->data)) {
return 'int';
}
if (is_double($this->data)) {
Expand Down
4 changes: 2 additions & 2 deletions src/wp-includes/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5105,7 +5105,7 @@ function _wp_array_get( $input_array, $path, $default_value = null ) {
}

if ( is_string( $path_element )
|| is_integer( $path_element )
|| is_int( $path_element )
|| null === $path_element
) {
/*
Expand Down Expand Up @@ -5182,7 +5182,7 @@ function _wp_array_set( &$input_array, $path, $value = null ) {

foreach ( $path as $path_element ) {
if (
! is_string( $path_element ) && ! is_integer( $path_element ) &&
! is_string( $path_element ) && ! is_int( $path_element ) &&
! is_null( $path_element )
) {
return;
Expand Down
Loading