Adjust the WP_ALLOW_COLLABORATION check in writing options#11322
Adjust the WP_ALLOW_COLLABORATION check in writing options#11322adamziel wants to merge 1 commit intoWordPress:trunkfrom
Conversation
The WP_ALLOW_COLLABORATION constant was introduced in PR WordPress#11311 to support disabling RTC at the host level or at the wp-config.php level. A part of that PR was hiding the "Enable RTC" checkbox in the writing options when RTC is explicitly disallowed via the constant. In the process of reviewing the change and merging suggestions, I have used the wrong condition to hide that checkbox. This PR makes the condition right. Props to @tyxla for noticing! \# Testing instructions * Set the WP_ALLOW_COLLABORATION constant to false, go to writing options, confirm the checkbox is replaced by a message "Real-time collaboration has been disabled". * Set it to true, confirm the checkbox is there. * Remove the constnat, confirm the checkbox is there.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
2 participants
The
WP_ALLOW_COLLABORATIONconstant was introduced in PR #11311 to support disabling RTC at the host level or at the wp-config.php level. A part of that PR was hiding the "Enable RTC" checkbox in the writing options when RTC is explicitly disallowed via the constant. In the process of reviewing the change and merging suggestions, I have used the wrong condition to hide that checkbox.This PR makes the condition right.
Props to @tyxla for noticing!
Testing instructions
cc @ellatrix