Conversation
Wulf
approved these changes
Jan 2, 2024
Owner
Wulf
left a comment
Wulf
left a comment
There was a problem hiding this comment.
awesome, looks good to me. Happy new year!
…:" prefix (like other functions)
and remove explicit import
hasezoey
force-pushed
the
someImportChanges
branch
from
2593230 to
0a55556
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR some some fixes for #94 by using the
diesel::prefix where possible.This PR does NOT completely fix issue #94 because of the trait imports, where i would like to have #114 ready so i can test completely what is necessary to import and what not, also to add some "conflicting names" tests as pointed out by #119