Rename Association#object_id to #xero_object_id to avoid shadowing Kernel#object_id#354
Open
peterc wants to merge 1 commit intoXeroAPI:masterfrom
Open
Rename Association#object_id to #xero_object_id to avoid shadowing Kernel#object_id#354peterc wants to merge 1 commit intoXeroAPI:masterfrom
peterc wants to merge 1 commit intoXeroAPI:masterfrom
Conversation
Author
|
Hope this can get merged soon. |
|
Yes, let's get this merged in. Thanks Peter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
object_idtoxero_object_idon theXeroRuby::Files::Associationmodel to avoid shadowingKernel#object_id, which is a core Ruby method that should never be overridden.ObjectId) is unchanged, so wire compatibility is preserved.FilesApiare unaffected (they useobject_idas a local parameter name, not a model accessor).Why this matters
Defining
attr_accessor :object_idon any Ruby object overridesKernel#object_id, which Ruby uses internally for object identity. This causes a warning (redefining 'object_id' may cause serious problems) and can lead to subtle bugs in equality checks, hash lookups, and debugging tools.