Skip to content

ci: update Slack notification workflow to use environment variables#2245

Open
anunay-xin wants to merge 1 commit intomainfrom
fix-slack-ci-error
Open

ci: update Slack notification workflow to use environment variables#2245
anunay-xin wants to merge 1 commit intomainfrom
fix-slack-ci-error

Conversation

@anunay-xin
Copy link
Copy Markdown
Collaborator

@anunay-xin anunay-xin commented Mar 27, 2026

Slack notification workflow to use environment variables for PR details

Proposed changes

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Summary by CodeRabbit

  • Chores
    • Improved Slack notification workflow configuration for better code organization and maintainability.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6fd3f09e-a7a4-49ae-a858-1c04970a3fe2

📥 Commits

Reviewing files that changed from the base of the PR and between 6fb59c9 and 839be8f.

📒 Files selected for processing (1)
  • .github/workflows/pr-notify-slack.yml

📝 Walkthrough

Walkthrough

This pull request refactors the Slack notification workflow step by moving environment variable assignments (PR_URL, PR_TITLE, PR_AUTHOR) from inline shell script to the step's env section, utilizing GitHub Actions context expressions (github.event.pull_request.*) for cleaner configuration.

Changes

Cohort / File(s) Summary
Workflow Environment Configuration
.github/workflows/pr-notify-slack.yml
Migrated PR_URL, PR_TITLE, and PR_AUTHOR variable definitions from shell script assignments to step-level env declarations using GitHub Actions context expressions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • liam-lai
  • wanwiset25
  • gzliudan

Poem

🐰 Hops of joy for cleaner configs, hooray!
Variables moved to env in a neater way,
No shell script clutter, just GitHub context dance,
Slack notifications sparkle—what a glance!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the Slack notification workflow to use environment variables for PR details.
Description check ✅ Passed The description includes the required template structure with the 'Proposed changes' section and properly marked the CI checkbox, though it lacks specific implementation details beyond the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-slack-ci-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants