[Cpp] Challenge 2 (Unreviewed)

[rbrtdambrosio]

No description provided.

[CLAassistant]

All committers have signed the CLA.

[jacktraf]

Getting the size of the array from the user is prone to error and could be dangerous in C, idk about C++. IMO it should determine the size of the array on its own

[rbrtdambrosio]

@jacktraf Thanks for the comment :) I'm interested in this. Why is dangerous in C? I don't know C very well so I would like to understand more about it.

[jacktraf]

Reading/writing past the end of a buffer/array in c/c++ is a big no no. Its classified as undefined behavior / buffer overflow (in the case of writing).
"In C the use of any automatic variable before it has been initialized yields undefined behavior, as does integer division by zero or indexing an array outside of its defined bounds (see buffer overflow)" https://en.m.wikipedia.org/wiki/Undefined_behavior

See also https://en.m.wikipedia.org/wiki/Buffer_overflow for possible security risks

[jacktraf]

Also, never trust user input

[rbrtdambrosio]

@jacktraf thanks for the answer :)
Yes i'm aware of the issues regarding the use of array beyond their end or without initialization.
I was only assuming a "legal" behavior from the user. If an integer value (in the int range) is used as array length there shouldn't be problem.
In any case it's an interesting point that I will keep in mind :)