Skip to content

🛡️ Sentinel: [CRITICAL/HIGH] Fix OverflowError thread crash vulnerability#40

Merged
ManupaKDU merged 1 commit intomainfrom
sentinel-fix-overflow-error-4475240439618510007
Apr 3, 2026
Merged

🛡️ Sentinel: [CRITICAL/HIGH] Fix OverflowError thread crash vulnerability#40
ManupaKDU merged 1 commit intomainfrom
sentinel-fix-overflow-error-4475240439618510007

Conversation

@ManupaKDU
Copy link
Copy Markdown
Contributor

🚨 Severity: HIGH
💡 Vulnerability: Application crashes and potential DoS due to OverflowError when untrusted input containing Infinity or NaN is parsed (e.g., from JSON) and subsequently converted to an integer using int(). The thread pool would crash because unhandled exceptions in ThreadPoolExecutor workers bubble up.
🎯 Impact: Denial of Service (DoS) vulnerability. By providing Infinity for the timeout via JSON or an API endpoint feeding this script, an attacker could immediately crash the underlying scanning worker thread pools.
🔧 Fix: Added explicit catch for OverflowError alongside ValueError and TypeError when parsing timeout within is_reachable.
✅ Verification: Ran python3 -m unittest test_testping1.py with 2 new unit tests specifically testing float('inf') and float('-inf') values for timeout, verifying they are gracefully blocked.


PR created automatically by Jules for task 4475240439618510007 started by @ManupaKDU

…lity in timeout integer cast

Added protection against OverflowError when casting the timeout parameter to an integer. Untrusted inputs like float infinity (from JSON/other sources) could crash the thread pool. Caught OverflowError explicitly, updated unit tests.

Co-authored-by: ManupaKDU <95234271+ManupaKDU@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ManupaKDU ManupaKDU merged commit 695e97e into main Apr 3, 2026
1 check passed
@manupawickramasinghe manupawickramasinghe deleted the sentinel-fix-overflow-error-4475240439618510007 branch April 8, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant