Draft
Conversation
EdCaunt
reviewed
Mar 27, 2025
| lib_dir = Path(metadata['lib_dirs'][-1]) | ||
|
|
||
| try: | ||
| cls.lib = ctypes.CDLL(lib_dir/'libpetsc.so') |
Collaborator
There was a problem hiding this comment.
Is this correct? Looks like division by a string unless I'm missing something
Collaborator
There was a problem hiding this comment.
lib_dir is a Path so maybe it overrides division to allow that
|
|
||
| def _alloc_C_libcall(self, size, ctype): | ||
| if not self.available(): | ||
| raise RuntimeError("...") |
| c_bytesize = ctypes.c_ulong(size * ctypes.sizeof(ctype)) | ||
| c_pointer = ctypes.cast(ctypes.c_void_p(), ctypes.c_void_p) | ||
|
|
||
| from devito.petsc.memory import op_memory |
Collaborator
There was a problem hiding this comment.
There are a couple of imports within functions here, which probably means things need moving around to prevent circular imports
…n not all functions are mem alloc via petsc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.