🎨 Palette: Fix keyboard focus trap in collapsed sidebar#98
🎨 Palette: Fix keyboard focus trap in collapsed sidebar#98
Conversation
- Added `focus-visible:opacity-100` to the hidden expand button in the sidebar to ensure it remains visible when focused via keyboard. - Added `id="app-sidebar"` to the sidebar `<aside>` element. - Added `aria-controls="app-sidebar"` to both sidebar toggle buttons. - Ensured `aria-expanded` attributes are correctly set. - Created `.Jules/palette.md` to document accessibility learnings regarding invisible focusable elements. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Added `focus-visible:opacity-100` to the hidden expand button in the sidebar to ensure it remains visible when focused via keyboard. - Added `id="app-sidebar"` to the sidebar `<aside>` element. - Added `aria-controls="app-sidebar"` to both sidebar toggle buttons. - Ensured `aria-expanded` attributes are correctly set. - Created `.Jules/palette.md` to document accessibility learnings regarding invisible focusable elements. - Fixed code formatting issues. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
- Added `focus-visible:opacity-100` to the hidden expand button in the sidebar to ensure it remains visible when focused via keyboard. - Added `id="app-sidebar"` to the sidebar `<aside>` element. - Added `aria-controls="app-sidebar"` to both sidebar toggle buttons. - Ensured `aria-expanded` attributes are correctly set. - Created `.Jules/palette.md` to document accessibility learnings regarding invisible focusable elements. - Fixed code formatting issues. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
- Added `focus-visible:opacity-100` to the hidden expand button in the sidebar to ensure it remains visible when focused via keyboard. - Added `id="app-sidebar"` to the sidebar `<aside>` element. - Added `aria-controls="app-sidebar"` to both sidebar toggle buttons. - Ensured `aria-expanded` attributes are correctly set. - Created `.Jules/palette.md` to document accessibility learnings regarding invisible focusable elements. - Fixed code formatting issues. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
1 participant
Improved keyboard accessibility by fixing a "focus black hole" where the sidebar expand button was invisible but focusable when the sidebar was collapsed. Also added proper ARIA attributes to sidebar controls.
PR created automatically by Jules for task 17016989375795285729 started by @aarjava