Skip to content

Comments

Fix case-sensitive address comparison in Merkl points incentives#2876

Closed
Copilot wants to merge 2 commits intofeat/blacklist-ink-campaignfrom
copilot/sub-pr-2875
Closed

Fix case-sensitive address comparison in Merkl points incentives#2876
Copilot wants to merge 2 commits intofeat/blacklist-ink-campaignfrom
copilot/sub-pr-2875

Conversation

Copy link
Contributor

Copilot AI commented Feb 16, 2026

General Changes

  • Fixes case-sensitive address comparison causing point opportunities to be filtered out unexpectedly

Developer Notes

The Merkl API may return token addresses in varying cases (lowercase vs checksummed). The previous implementation used case-sensitive comparison with a checksummed hardcoded address, causing mismatches.

Changes:

  • Normalized INK_POINT_TOKEN_ADDRESSES to lowercase
  • Added .toLowerCase() to all three address comparisons (filtering, finding, validation)

Before:

const INK_POINT_TOKEN_ADDRESSES = ['0x40aBd730Cc9dA34a8EE9823fEaBDBa35E50c4ac7'];
// ...
INK_POINT_TOKEN_ADDRESSES.includes(breakdown.token.address)

After:

const INK_POINT_TOKEN_ADDRESSES = ['0x40abd730cc9da34a8ee9823feabdba35e50c4ac7'];
// ...
INK_POINT_TOKEN_ADDRESSES.includes(breakdown.token.address.toLowerCase())

Follows existing pattern in the file (lines 84, 86) for address comparisons.


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Feb 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
interface Ready Ready Preview, Comment Feb 16, 2026 11:27am

Request Review

Co-authored-by: AGMASO <95312462+AGMASO@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix API inconsistency and URL update issues Fix case-sensitive address comparison in Merkl points incentives Feb 16, 2026
Copilot AI requested a review from AGMASO February 16, 2026 11:23
@AGMASO AGMASO closed this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants