Copilot/resolve pull request conflicts#15
Copilot/resolve pull request conflicts#15ThePlenkov wants to merge 5 commits intoabapify:copilot/resolve-pull-request-conflictsfrom
Conversation
PR Compliance Guide 🔍(Compliance updated until commit cc35a5d)Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label Previous compliance checksCompliance check up to commit ee8d695
|
||||||||||||||||||||||||||||||||||||||||||||||||||
PR Code Suggestions ✨Latest suggestions up to cc35a5d
Previous suggestionsSuggestions up to commit ee8d695
|
||||||||||||||||||||||||||||||
|
View your CI Pipeline Execution ↗ for commit 2684f68
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Add eslint-disable comments for intentional no-empty-function patterns in @abapify/logger, @abapify/browser-auth, and @abapify/adt-playwright - Fix adt-tui unnecessary escape characters in RegExp constructor string - Add eslint-disable for no-empty-object-type in speci helpers/tests and nx-sync empty interface schema - Fix adt-plugin-abapgit, asjson-parser, adt-cli eslint.config.js to import from correct root eslint.config.mjs path - Suppress circular dependency lint error in adt-contracts config file - Add passWithNoTests to adt-puppeteer vitest config Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Add "types" export condition in adk/package.json pointing to source
TypeScript now resolves @abapify/adk types without requiring a dist build
- Convert dynamic import('@abapify/adk') in service.ts to static imports
The dynamic imports caused nx to mark adk as "lazy-loaded", which flagged
all static imports across adt-cli as module boundary violations
- Remove all eslint-disable @nx/enforce-module-boundaries workaround comments
that were added as a result of the lazy-loaded false positive
- Fix remaining adt-cli lint errors now visible after eslint.config.js fix:
prefer-const, no-useless-escape, no-inferrable-types, no-empty-function
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
These changes fix the lint errors introduced by recent formatting changes. We resolved the empty arrow function error by adding an explanatory comment, replaced the problematic {} type with Record<string, never>, and removed unused eslint-disable directives while properly targeting the specific any type that requires suppression.
Tip
✅ We verified this fix by re-running speci:lint.
Suggested Fix changes
diff --git a/packages/adt-puppeteer/src/adapter.ts b/packages/adt-puppeteer/src/adapter.ts
index 6c28802..07e54ac 100644
--- a/packages/adt-puppeteer/src/adapter.ts
+++ b/packages/adt-puppeteer/src/adapter.ts
@@ -87,7 +87,9 @@ export function createPuppeteerAdapter(): BrowserAdapter {
waitUntil: 'domcontentloaded',
timeout: options?.timeout ?? 30000,
})
- .catch(() => {});
+ .catch(() => {
+ // Ignore navigation errors - page may already be loaded or navigation may be interrupted
+ });
},
async getCookies(): Promise<CookieData[]> {
diff --git a/packages/speci/examples/global-error-responses.ts b/packages/speci/examples/global-error-responses.ts
index a486549..1087e91 100644
--- a/packages/speci/examples/global-error-responses.ts
+++ b/packages/speci/examples/global-error-responses.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-empty-object-type */
/**
* Example: Using a global error response map with createHttp
*
@@ -17,11 +16,11 @@ import {
interface ApiError {
code: string;
message: string;
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
details?: Record<string, any>;
}
// 2. Define your global error response map
-/* eslint-disable @typescript-eslint/no-empty-object-type */
const globalErrors = {
400: {} as ApiError,
401: {} as ApiError,
@@ -29,7 +28,6 @@ const globalErrors = {
404: {} as ApiError,
500: {} as ApiError,
} as const;
-/* eslint-enable @typescript-eslint/no-empty-object-type */
// 3. Create http instance with global errors
const api = createHttp(globalErrors);
diff --git a/packages/speci/src/rest/inferrable.test.ts b/packages/speci/src/rest/inferrable.test.ts
index 7338406..b239f4b 100644
--- a/packages/speci/src/rest/inferrable.test.ts
+++ b/packages/speci/src/rest/inferrable.test.ts
@@ -22,7 +22,7 @@ describe('InferSchema with complex types', () => {
? E extends Record<string, unknown>
? { data: string }
: never
- : {};
+ : Record<string, never>;
// Simulate SpeciSchema - like adt-schemas does
type SimulatedSpeciSchema<T> = T & Serializable<SimulatedInferXsd<T>>;
Warning
Or Apply changes locally with:
npx nx-cloud apply-locally s3Yg-CPGs
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
ThePlenkov
changed the base branch from
feature/atc-checks
to
copilot/resolve-pull-request-conflicts
…solve-pull-request-conflicts
1 participant
PR Type
Enhancement, Documentation
Description
Add comprehensive CI monitoring skill with self-healing fix orchestration
Implement CI monitor subagent for polling Nx Cloud pipeline status
Add Nx workspace exploration and code generation skills
Simplify devcontainer configuration and add bun installation
Diagram Walkthrough
File Walkthrough
9 files
Add monitor-ci prompt for CI orchestrationAdd monitor-ci skill with self-healing workflowsAdd CI monitor subagent for status pollingAdd Nx workspace exploration skillAdd Nx code generation skillAdd workspace package linking skillAdd Nx task execution skillAdd Nx plugin discovery skillAdd bun package manager installation2 files
Add affected projects reference documentationAdd nx configuration markers and formatting1 files
Simplify devcontainer mounts and post-create commands1 files
Remove frozen lockfile constraint from bun install3 files