Skip to content

Revive screenshots component#9

Open
drzax wants to merge 2 commits intomainfrom
revamp-screenshots
Open

Revive screenshots component#9
drzax wants to merge 2 commits intomainfrom
revamp-screenshots

Conversation

@drzax
Copy link
Copy Markdown
Member

@drzax drzax commented Feb 17, 2026

This is slightly more than a revival — it's a rather large revamp including breaking changes.

I wanted to simplify the code a little but the key change is introducing two function props which dramatically increase flexibility:

  • getGraphicLocation: return a URL object that points to the rendered graphic for a given marker
  • getGeneratorRequest: return a Request object that can be used to call the screenshots API

These make it possible to use the component with graphics that live in unexpected locations and utilise alternative screenshot services without changing the component (should the default service disappear).

@drzax drzax requested a review from AshKyd February 17, 2026 21:43
Copy link
Copy Markdown
Member

@AshKyd AshKyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Add some docs/copy-paste example and let's goooo11!~

@drzax drzax marked this pull request as ready for review February 17, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants