rename spaces get-all to get to align with the rest of the cli#192
Open
umair-ably wants to merge 2 commits intomainfrom
Open
rename spaces get-all to get to align with the rest of the cli#192umair-ably wants to merge 2 commits intomainfrom
umair-ably wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR renames all Changes
Review Notes
|
sacOO7
reviewed
Mar 26, 2026
| "$ ably spaces locks get my-space", | ||
| "$ ably spaces locks get my-space --json", | ||
| "$ ably spaces locks get my-space my-lock", | ||
| "$ ably spaces locks get my-space my-lock --json", |
Contributor
There was a problem hiding this comment.
Suggested change
| "$ ably spaces locks get my-space my-lock --json", | |
| "$ ably spaces locks get my-space my-lock --json", | |
| "$ ably spaces locks get my-space my-lock --pretty-json", |
All other spaces get commands show three examples (plain, --json, --pretty-json):
sacOO7
reviewed
Mar 26, 2026
| static override examples = [ | ||
| "$ ably spaces locks get my-space", | ||
| "$ ably spaces locks get my-space --json", | ||
| "$ ably spaces locks get my-space my-lock", |
Contributor
There was a problem hiding this comment.
Suggested change
| "$ ably spaces locks get my-space my-lock", | |
| "$ ably spaces locks get my-space lock-id", |
Seems, you can query any lock by it's lock-id instead of just your own lock -> https://ably.com/docs/spaces/locking#query.
Same is applicable for all commands
sacOO7
reviewed
Mar 26, 2026
|
|
||
| try { | ||
| await this.initializeSpace(flags, spaceName, { | ||
| enterSpace: false, |
Contributor
There was a problem hiding this comment.
Suggested change
| enterSpace: false, | |
| enterSpace: true, |
Existing bug, was trying to fix as a part of #185
- The SDK's
Locksclass stores locks in aMap<lockId, Map<connectionId, Lock>>and it starts empty. - So, it returns empty locks even when locks are set on space
enterSpace: truemakes sure proper syncing happens before accessing map.
Ably capabilities are operation-based, not clientId-based, so client identity is irrelevant for pure read queries. Removed clientIdFlag from spaces members/locations/cursors/locks get and rooms occupancy get. Updated docs and skills to clarify when --client-id should be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames all spaces * get-all subcommands to spaces * get for consistency with the rest of the CLI. For spaces locks, the two separate commands (get and get-all) are merged into a single get command where LOCKID is now optional — omitting it returns all locks, providing it returns a single lock.