Skip to content

docs: add Apple Silicon setup note to CONTRIBUTING#4665

Closed
Gopal7387 wants to merge 1 commit intoaboutcode-org:developfrom
Gopal7387:docs/apple-silicon-contributing
Closed

docs: add Apple Silicon setup note to CONTRIBUTING#4665
Gopal7387 wants to merge 1 commit intoaboutcode-org:developfrom
Gopal7387:docs/apple-silicon-contributing

Conversation

@Gopal7387
Copy link
Copy Markdown

This PR adds a short Apple Silicon (M1/M2/M3/M4) note to CONTRIBUTING.rst
to warn contributors about ARM64 dependency limitations and document a
tested x86_64/Rosetta workaround.

Fixes #4650.

Copy link
Copy Markdown
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gopu0106, please see comments for your consideration

It also seems like this PR is exactly same to #4663 and was opened after the other one was opened. While it is fine for two contributors to work on something, you should try to collaborate before opening another PR, and if you use parts from another PR, you should credit them.

Comment thread CONTRIBUTING.rst

.. code-block:: bash

arch -x86_64 /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we should not include installation instructions for other packages directly (as it might change and our docs will become outdated, might have other requirements/prerequisites). Instead use a link to their installation docs

Comment thread CONTRIBUTING.rst
Some native dependencies do not provide ARM64 wheels. Using ARM64 Python
(e.g., Homebrew Python on Apple Silicon) may cause ``./configure --dev``
to fail. A tested workaround is to use x86_64 Python under Rosetta.
See issue #3205 for additional context.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are including a reference to an issue, why not also link this?

@Gopal7387
Copy link
Copy Markdown
Author

Thanks for pointing this out.
@AyanSinhaMahapatra
I didn’t realize PR #4663 was already covering the same change when I opened this and sorry about the duplication.
I understand the need to coordinate earlier.

I can update the references to include proper links and remove the inline install commands in favor of linking to the official docs.
Let me know whether you’d prefer me to close this PR in favor of #4663 or rework this one.
Happy to follow whatever you think is best.

@Gopal7387 Gopal7387 closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.rst: Missing Apple Silicon setup instructions - ./configure --dev fails on M1/M2/M3

2 participants