Open
Conversation
michaelehab
moved this to In Progress
in GSoC 2025: On-demand live evaluation of packages and integration with VulnTotal @michaelehab
ziadhany
requested changes
Aug 14, 2025
vulnerabilities/importers/curl.py
Outdated
Comment on lines
+89
to
+91
| except Exception as e: | ||
| logger.error(f"Error checking version {self.purl.version}: {e}") | ||
| continue |
Collaborator
There was a problem hiding this comment.
Better catch specific exceptions InvalidVersion
vulnerabilities/importers/curl.py
Outdated
Comment on lines
+43
to
+49
| super().__init__(*args, **kwargs) | ||
| self.purl = purl | ||
| if self.purl: | ||
| if self.purl.type != "generic" or self.purl.name != "curl": | ||
| print( | ||
| f"Warning: This importer handles curl package vulnerabilities. Current PURL: {self.purl!s}" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| super().__init__(*args, **kwargs) | |
| self.purl = purl | |
| if self.purl: | |
| if self.purl.type != "generic" or self.purl.name != "curl": | |
| print( | |
| f"Warning: This importer handles curl package vulnerabilities. Current PURL: {self.purl!s}" | |
| ) | |
| super().__init__(*args, **kwargs) | |
| self.purl = purl | |
| if self.purl and (self.purl.type != "generic" or self.purl.name != "curl"): | |
| print( | |
| f"Warning: This importer handles curl package vulnerabilities. Current PURL: {self.purl!s}" | |
| ) | |
* Add Curl Live V2 Importer * Add tests for the Curl Live V2 Importer * Tested functionally using the Live Evaluation API in #1969 Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
michaelehab
force-pushed
the
1918-curl-importer-package-first
branch
from
f228798 to
5c8f008
Compare
Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
michaelehab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1918