Open
Conversation
michaelehab
requested review from
TG1999 and
keshav-space
and removed request for
TG1999
TG1999
reviewed
Jul 15, 2025
| @classmethod | ||
| def steps(cls): | ||
| return ( | ||
| return [ |
Collaborator
Author
There was a problem hiding this comment.
It should be a tuple as well to maintain code consistency. I will change this.
TG1999
reviewed
Jul 15, 2025
| advisory_files = filtered_files | ||
|
|
||
| for advisory in list(advisory_files): | ||
| for result in self.to_advisory_data(advisory): |
Contributor
There was a problem hiding this comment.
Why we are not using yield from here ?
Collaborator
Author
There was a problem hiding this comment.
Do you mean?
for advisory in list(advisory_files):
yield from self.to_advisory_data(advisory)
TG1999
reviewed
Jul 15, 2025
| advisory_files = list(vuln_directory.glob("*.json")) | ||
|
|
||
| if not self.is_batch_run: | ||
| package_name = self.purl.name |
Contributor
There was a problem hiding this comment.
Why we not actually check in our DB if the purl exists, before even checking all files ?
Collaborator
Author
There was a problem hiding this comment.
How does that guarantee that we won't find new advisories if we have the purl in DB?
As far as I understand, in order to find out whether we have new advisories, we have to check all files.
* Add NPM Live V2 Importer * Add tests for the NPM Live V2 Importer * Tested functionally using the Live Evaluation API in #1969 Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
michaelehab
force-pushed
the
1936-npm-importer-package-first
branch
from
5267b18 to
d803c6a
Compare
michaelehab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1936