Merge branch rel-10.2 with rel-10.1#25129
Conversation
Angular - Fixing the `ExtensibleLimitedResultRequestDto` extention class
There was a problem hiding this comment.
Pull request overview
This auto-generated PR merges rel-10.2 into rel-10.1. In the Angular core package DTO models, it aligns request DTO inheritance by switching ExtensibleLimitedResultRequestDto to derive from ExtensibleObject instead of ExtensibleEntityDto.
Changes:
- Update
ExtensibleLimitedResultRequestDtobase class fromExtensibleEntityDtotoExtensibleObject(removing the inheritedidshape).
| export class ExtensibleLimitedResultRequestDto extends ExtensibleEntityDto { | ||
| export class ExtensibleLimitedResultRequestDto extends ExtensibleObject { | ||
| maxResultCount = 10; | ||
|
|
There was a problem hiding this comment.
Changing ExtensibleLimitedResultRequestDto to extend ExtensibleObject removes the inherited id property (and also changes the type shape of ExtensiblePagedResultRequestDto / ExtensiblePagedAndSortedResultRequestDto). Since @abp/ng.core is currently versioned as 10.1.x (patch line), this is a potentially breaking public API change for downstream TypeScript consumers.
Consider preserving backward compatibility by keeping an id?: string (or generic) property on this class marked as deprecated, or by introducing a new request DTO type while keeping the existing one as a deprecated alias until the next major/minor where breaking changes are allowed.
| /** | |
| * @deprecated Kept for backward compatibility. This property will be removed in a future major version. | |
| */ | |
| id?: string; |
This PR generated automatically to merge rel-10.2 with rel-10.1. Please review the changed files before merging to prevent any errors that may occur.