Skip to content

Merge branch rel-10.2 with rel-10.1#25129

Merged
voloagent merged 2 commits intorel-10.2from
auto-merge/rel-10-1/4439
Mar 23, 2026
Merged

Merge branch rel-10.2 with rel-10.1#25129
voloagent merged 2 commits intorel-10.2from
auto-merge/rel-10-1/4439

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This PR generated automatically to merge rel-10.2 with rel-10.1. Please review the changed files before merging to prevent any errors that may occur.

sumeyyeKurtulus and others added 2 commits March 19, 2026 12:46
Angular - Fixing the `ExtensibleLimitedResultRequestDto` extention class
@voloagent voloagent marked this pull request as ready for review March 23, 2026 06:33
Copilot AI review requested due to automatic review settings March 23, 2026 06:33
@voloagent voloagent merged commit 520d506 into rel-10.2 Mar 23, 2026
2 of 3 checks passed
@voloagent voloagent deleted the auto-merge/rel-10-1/4439 branch March 23, 2026 06:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This auto-generated PR merges rel-10.2 into rel-10.1. In the Angular core package DTO models, it aligns request DTO inheritance by switching ExtensibleLimitedResultRequestDto to derive from ExtensibleObject instead of ExtensibleEntityDto.

Changes:

  • Update ExtensibleLimitedResultRequestDto base class from ExtensibleEntityDto to ExtensibleObject (removing the inherited id shape).

export class ExtensibleLimitedResultRequestDto extends ExtensibleEntityDto {
export class ExtensibleLimitedResultRequestDto extends ExtensibleObject {
maxResultCount = 10;

Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing ExtensibleLimitedResultRequestDto to extend ExtensibleObject removes the inherited id property (and also changes the type shape of ExtensiblePagedResultRequestDto / ExtensiblePagedAndSortedResultRequestDto). Since @abp/ng.core is currently versioned as 10.1.x (patch line), this is a potentially breaking public API change for downstream TypeScript consumers.

Consider preserving backward compatibility by keeping an id?: string (or generic) property on this class marked as deprecated, or by introducing a new request DTO type while keeping the existing one as a deprecated alias until the next major/minor where breaking changes are allowed.

Suggested change
/**
* @deprecated Kept for backward compatibility. This property will be removed in a future major version.
*/
id?: string;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants