Skip to content

Merge branch dev with rel-10.2#25132

Merged
maliming merged 8 commits intodevfrom
auto-merge/rel-10-2/4442
Mar 23, 2026
Merged

Merge branch dev with rel-10.2#25132
maliming merged 8 commits intodevfrom
auto-merge/rel-10-2/4442

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This PR generated automatically to merge dev with rel-10.2. Please review the changed files before merging to prevent any errors that may occur.

@maliming maliming marked this pull request as ready for review March 23, 2026 06:45
Copilot AI review requested due to automatic review settings March 23, 2026 06:45
@maliming maliming merged commit af6e18a into dev Mar 23, 2026
7 of 10 checks passed
@maliming maliming deleted the auto-merge/rel-10-2/4442 branch March 23, 2026 06:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Automated merge PR from dev into rel-10.2, bringing in a small set of changes across Angular core DTO models, documentation updates for Identity/CMS Kit user lookup integration, and a dependency version bump.

Changes:

  • Updated the Angular ExtensibleLimitedResultRequestDto inheritance in @abp/ng.core.
  • Added documentation for Identity external user lookup/integration service usage and CMS Kit remote user lookup integration.
  • Bumped Scriban from 6.3.0 to 6.6.0 and recorded it in the package version change log.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
npm/ng-packs/packages/core/src/lib/models/dtos.ts Changes the base type of ExtensibleLimitedResultRequestDto (public Angular DTO API surface).
docs/en/package-version-changes.md Adds a new 10.2.0-rc.3 entry documenting the Scriban upgrade.
docs/en/modules/identity.md Documents external user lookup service behavior and remote Identity integration configuration guidance.
docs/en/modules/cms-kit/index.md Documents CMS Kit user lookup integration with remote Identity integration endpoints.
Directory.Packages.props Updates Scriban package version to 6.6.0.
Comments suppressed due to low confidence (1)

npm/ng-packs/packages/core/src/lib/models/dtos.ts:61

  • ExtensibleLimitedResultRequestDto is part of the public @abp/ng.core API (re-exported from models/index.ts). Changing its base type from ExtensibleEntityDto to ExtensibleObject removes the (previously inherited) id?: string member and can break downstream TypeScript builds that were accessing dto.id. If the goal is just to avoid the semantic implication of an entity DTO, consider keeping backward compatibility (e.g., keep the old shape via a deprecated id?: string on the class) or ensure this is treated/documented as a breaking change in the package versioning/release notes.
export class ExtensibleLimitedResultRequestDto extends ExtensibleObject {
  maxResultCount = 10;

  constructor(initialValues: Partial<ExtensibleLimitedResultRequestDto> = {}) {
    super(initialValues);
  }


### External User Lookup Service

`UserLookupService<TUser, TUserRepository>` first queries the local user store. If an `IExternalUserLookupServiceProvider` implementation is available, it can also query an external source, create the local copy of the user and keep the local data synchronized.
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section says the external lookup “keeps the local data synchronized”, but UserLookupService skips external lookup when a local user exists by default (SkipExternalLookupIfLocalUserExists = true). That means existing local users won’t be refreshed unless a derived lookup service opts out, and updates only occur when the local user implements IUpdateUserData. Consider adding a short note clarifying these prerequisites/limits so readers don’t assume synchronization happens automatically in all cases.

Suggested change
`UserLookupService<TUser, TUserRepository>` first queries the local user store. If an `IExternalUserLookupServiceProvider` implementation is available, it can also query an external source, create the local copy of the user and keep the local data synchronized.
`UserLookupService<TUser, TUserRepository>` first queries the local user store. If an `IExternalUserLookupServiceProvider` implementation is available, it can also query an external source, create the local copy of the user and keep the local data synchronized. Note that, by default, it skips the external lookup when a local user already exists (`SkipExternalLookupIfLocalUserExists = true`), and updating existing local users requires both a derived lookup service that opts into refreshing them and a local user type that implements `IUpdateUserData`.

Copilot uses AI. Check for mistakes.
Comment thread docs/en/modules/cms-kit/index.md
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 34.93409% with 691 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.34%. Comparing base (5eaffd2) to head (520d506).
⚠️ Report is 88 commits behind head on dev.

Files with missing lines Patch % Lines
...olo.Abp.Data/Volo/Abp/Data/DataFilterExtensions.cs 0.00% 154 Missing ⚠️
...Abp/EntityFrameworkCore/Auditing/Auditing_Tests.cs 0.00% 119 Missing ⚠️
.../ChangeTracking/ChangeTrackingInterceptor_Tests.cs 0.00% 75 Missing ⚠️
...e/Mvc/ModelBinding/ModelBindingController_Tests.cs 0.00% 59 Missing ⚠️
...iLingualObjects/MultiLingualObjectManager_Tests.cs 0.00% 45 Missing ⚠️
...c/ApiExploring/AbpApiDefinitionController_Tests.cs 0.00% 39 Missing ⚠️
...Injection/CookieAuthenticationOptionsExtensions.cs 0.00% 34 Missing ⚠️
...NetCore/Mvc/ModelBinding/ModelBindingController.cs 0.00% 26 Missing ⚠️
.../Abp/ApplicationInitializationContextExtensions.cs 0.00% 24 Missing ⚠️
...Resources/ClientResourcePermissionValueProvider.cs 32.14% 17 Missing and 2 partials ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #25132      +/-   ##
==========================================
- Coverage   50.64%   50.34%   -0.30%     
==========================================
  Files        3465     3450      -15     
  Lines      116732   116129     -603     
  Branches     8819     8756      -63     
==========================================
- Hits        59116    58470     -646     
- Misses      55817    55885      +68     
+ Partials     1799     1774      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants