Conversation
Angular - Fixing the `ExtensibleLimitedResultRequestDto` extention class
Upgrade Scriban to 6.6.0
…-lookup-docs docs: explain external user lookup for Identity and CMS Kit
Merge branch rel-10.2 with rel-10.1
There was a problem hiding this comment.
Pull request overview
Automated merge PR from dev into rel-10.2, bringing in a small set of changes across Angular core DTO models, documentation updates for Identity/CMS Kit user lookup integration, and a dependency version bump.
Changes:
- Updated the Angular
ExtensibleLimitedResultRequestDtoinheritance in@abp/ng.core. - Added documentation for Identity external user lookup/integration service usage and CMS Kit remote user lookup integration.
- Bumped Scriban from
6.3.0to6.6.0and recorded it in the package version change log.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| npm/ng-packs/packages/core/src/lib/models/dtos.ts | Changes the base type of ExtensibleLimitedResultRequestDto (public Angular DTO API surface). |
| docs/en/package-version-changes.md | Adds a new 10.2.0-rc.3 entry documenting the Scriban upgrade. |
| docs/en/modules/identity.md | Documents external user lookup service behavior and remote Identity integration configuration guidance. |
| docs/en/modules/cms-kit/index.md | Documents CMS Kit user lookup integration with remote Identity integration endpoints. |
| Directory.Packages.props | Updates Scriban package version to 6.6.0. |
Comments suppressed due to low confidence (1)
npm/ng-packs/packages/core/src/lib/models/dtos.ts:61
ExtensibleLimitedResultRequestDtois part of the public@abp/ng.coreAPI (re-exported frommodels/index.ts). Changing its base type fromExtensibleEntityDtotoExtensibleObjectremoves the (previously inherited)id?: stringmember and can break downstream TypeScript builds that were accessingdto.id. If the goal is just to avoid the semantic implication of an entity DTO, consider keeping backward compatibility (e.g., keep the old shape via a deprecatedid?: stringon the class) or ensure this is treated/documented as a breaking change in the package versioning/release notes.
export class ExtensibleLimitedResultRequestDto extends ExtensibleObject {
maxResultCount = 10;
constructor(initialValues: Partial<ExtensibleLimitedResultRequestDto> = {}) {
super(initialValues);
}
|
|
||
| ### External User Lookup Service | ||
|
|
||
| `UserLookupService<TUser, TUserRepository>` first queries the local user store. If an `IExternalUserLookupServiceProvider` implementation is available, it can also query an external source, create the local copy of the user and keep the local data synchronized. |
There was a problem hiding this comment.
This section says the external lookup “keeps the local data synchronized”, but UserLookupService skips external lookup when a local user exists by default (SkipExternalLookupIfLocalUserExists = true). That means existing local users won’t be refreshed unless a derived lookup service opts out, and updates only occur when the local user implements IUpdateUserData. Consider adding a short note clarifying these prerequisites/limits so readers don’t assume synchronization happens automatically in all cases.
| `UserLookupService<TUser, TUserRepository>` first queries the local user store. If an `IExternalUserLookupServiceProvider` implementation is available, it can also query an external source, create the local copy of the user and keep the local data synchronized. | |
| `UserLookupService<TUser, TUserRepository>` first queries the local user store. If an `IExternalUserLookupServiceProvider` implementation is available, it can also query an external source, create the local copy of the user and keep the local data synchronized. Note that, by default, it skips the external lookup when a local user already exists (`SkipExternalLookupIfLocalUserExists = true`), and updating existing local users requires both a derived lookup service that opts into refreshing them and a local user type that implements `IUpdateUserData`. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #25132 +/- ##
==========================================
- Coverage 50.64% 50.34% -0.30%
==========================================
Files 3465 3450 -15
Lines 116732 116129 -603
Branches 8819 8756 -63
==========================================
- Hits 59116 58470 -646
- Misses 55817 55885 +68
+ Partials 1799 1774 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR generated automatically to merge dev with rel-10.2. Please review the changed files before merging to prevent any errors that may occur.