Change SendReport & sendDate "id" values from 16 to 8bits#40
Open
forderud wants to merge 1 commit intoabratchik:masterfrom
Open
Change SendReport & sendDate "id" values from 16 to 8bits#40forderud wants to merge 1 commit intoabratchik:masterfrom
forderud wants to merge 1 commit intoabratchik:masterfrom
Conversation
forderud
force-pushed
the
hid-report-8bit
branch
from
01f9c5b to
19675eb
Compare
The underlying HID_::sendReport method is anyhow only transmitting the first byte of the "id" field, so the content of the second byte is currently ignored. One can then just as well change the "id" argument type from 16 to 8bits. Update the HIDPowerDevice_::sendDate the same way, since it's just passing on the "id" argument to HID_::sendReport.
forderud
force-pushed
the
hid-report-8bit
branch
from
19675eb to
cb066ff
Compare
forderud
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying
HID_::sendReportmethod is anyhow only transmitting the first byte of the "id" field, so the content of the second byte is currently ignored. One can then just as well change the "id" argument type from 16 to 8bits.Update the
HIDPowerDevice_::sendDatethe same way, since it's just passing on the "id" argument toHID_::sendReport.This also makes the HID class more similar to the upstream Arduino implementation on https://github.com/arduino/ArduinoCore-avr/blob/master/libraries/HID/src/HID.h#L96 that is already using
uint8_tfor HID report IDs. This is consistent with the HID specification, that states that ReportID values are 8bits.