feat: add a parameter to disable type matching by content #1527
Open
RoCat wants to merge 1 commit intoacacode:mainfrom
Open
feat: add a parameter to disable type matching by content #1527RoCat wants to merge 1 commit intoacacode:mainfrom
RoCat wants to merge 1 commit intoacacode:mainfrom
Conversation
|
a9ded52 to
de5302d
Compare
de5302d to
ffe0344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reasons, types are matched by content.
For exemple if we have an API that only get as body an array of integers, with no type name, this type will match other type declared as array of integer with a name.
This could have sense sometimes, but in our case we dont want for exemple that an array of ids match Boundaries type, that is an array of coordinates.
For this reasons I added a parameter to disable the content matching feature.