[policy_tracker] Docs: Add README.md for the policy_tracker module#10350
Merged
[policy_tracker] Docs: Add README.md for the policy_tracker module#10350
Conversation
Collaborator
|
@skarya22 I think you're the one who knows the policy_tracker the best, can you review? |
skarya22
requested changes
Feb 10, 2026
Contributor
skarya22
left a comment
skarya22
left a comment
There was a problem hiding this comment.
Looks good, just a few quick comments
Co-authored-by: Saagar Arya <51128536+skarya22@users.noreply.github.com>
Contributor
Author
|
@skarya22 Thank you for the feedback I've incorporated all suggestions. |
skarya22
requested changes
Mar 3, 2026
| - `ModuleID`: FK to the `modules` table, each Policy is assigned to a module which determines when and how it is shown. | ||
| - `Content`: HTML content of the policy text. | ||
| - `SwalTitle`: Title displayed in the modal window. | ||
| - `PolicyRenewalTime`: Number of units (e.g., 365) for renewal. |
Contributor
There was a problem hiding this comment.
Can you change this to 7 since the default in the table is 7 days
Contributor
Author
There was a problem hiding this comment.
Sure, I've incorporated both the changes.
Co-authored-by: Saagar Arya <51128536+skarya22@users.noreply.github.com>
skarya22
approved these changes
Mar 3, 2026
Contributor
skarya22
left a comment
skarya22
left a comment
There was a problem hiding this comment.
Thanks Arnav! Looks great
skarya22
added
the
Passed manual tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Added README.md for the
policy_trackermodule.Documented its functionality and configuration consistent with other module READMEs.