Closed
Conversation
pxrl
reviewed
Jan 16, 2026
Collaborator
pxrl
left a comment
pxrl
left a comment
There was a problem hiding this comment.
Nice - great to see some more dependencies dropping off!
| files: ["test/**/*.ts", "hardhat.config.ts", "tasks/*.ts"], | ||
| rules: { | ||
| "no-restricted-imports": "off", | ||
| "node/no-missing-import": "off", |
Collaborator
There was a problem hiding this comment.
@fusmanii Curious on this one - what issue does it solve?
Contributor
Author
There was a problem hiding this comment.
I am importing test utils from "@across-protocol/sdk/test-utils" and the linter doesn't seem to like that, gives me error "@across-protocol/sdk/test-utils" is not found node/no-missing-import
…al/use-sdk-test-utils
The SDK's BundleDataClient skips historical deposit queries for fills with non-infinite fill deadlines. Since current SpokePool contracts don't allow infinite fill deadlines, the historical query path can't be triggered with new deposits. Updated tests to expect fills without in-memory deposits to be marked as invalid rather than found via historical query. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The SDK's BundleDataClient skips historical deposit queries for slow fill requests with non-infinite fill deadlines. Since current SpokePool contracts don't allow infinite fill deadlines, the historical query path can't be triggered with new deposits. Updated tests to expect slow fill requests without in-memory deposits to be marked as invalid rather than found via historical query. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…al/use-sdk-test-utils
fusmanii
commented
Feb 5, 2026
| @@ -697,7 +697,8 @@ describe("Dataworker: Load bundle data", async function () { | |||
| const fills = spokePoolClient_2.getFills(); | |||
Contributor
Author
There was a problem hiding this comment.
I think these tests fixes are needed because of this, claude did the heavy lifting here, ptal
fusmanii
requested review from
bmzig,
dohaki,
mrice32 and
nicholaspai
as code owners
…al/use-sdk-test-utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up after contracts repo test utils have been migrated to sdk in here