Open
Conversation
As was done with the refiller config, compress the monitor config to make it more manageable.
pxrl
requested review from
bmzig,
dohaki,
mrice32 and
nicholaspai
as code owners
| if (MONITORED_BALANCES) { | ||
| const validate = (chainId: number, account: string, warnThreshold: number, errorThreshold: number) => { | ||
| if (!isDefined(errorThreshold) && !isDefined(warnThreshold)) { | ||
| throw new Error("Must provide either an errorThreshold or a warnThreshold"); |
Contributor
There was a problem hiding this comment.
Should we throw even if just one value of error/warn threshold is not provided?
Tbh, i would prefer it more like that
pxrl
commented
Jan 30, 2026
| Object.entries(config).forEach(([account, chainConfig]) => { | ||
| Object.entries(chainConfig).forEach(([_chainId, tokenConfig]) => { | ||
| const chainId = Number(_chainId); | ||
| const { warnThreshold, errorThreshold, token } = tokenConfig; |
Collaborator
Author
There was a problem hiding this comment.
I think tokenConfig probably needs to be an array to permit multiple tokens to be monitored for a given account per chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was done with the refiller config, compress the monitor config to
make it more manageable.
Additionally, prefer the new refiller config over the old during the
transition phase.