improve(relayer): Tighten automatic slow fill request logic#2972
Merged
improve(relayer): Tighten automatic slow fill request logic#2972
Conversation
pxrl
requested review from
bmzig,
dohaki,
mrice32 and
nicholaspai
as code owners
pxrl
force-pushed
the
pxrl/slowFillArg
branch
from
7c7fa7b to
a563013
Compare
The existing logic of submitting slow fill requests for any supported & unfilled deposit causes a lot of unnecessary slow fill requests to be submitted. This has caused some collisions with other, more important transactions. Ideally we might drop slow fill requests entirely; for now, just require that the deposits are actually profitable for a slow fill request to be submitted.
nicholaspai
previously approved these changes
Feb 20, 2026
pxrl
commented
Feb 20, 2026
bmzig
reviewed
Feb 23, 2026
nicholaspai
approved these changes
Mar 10, 2026
Collaborator
Author
|
@codex Please review. The change in logic is deliberate - unprofitable deposits should no longer result in slow fill requests being submitted. Slow fill requests should still be submitted where the relayer has insufficient capital for a fast fill, when slow fills are enabled by config. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1444bb1dcf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing logic of submitting slow fill requests for any supported &
unfilled deposit causes a lot of unnecessary slow fill requests to be
submitted. This has caused some collisions with other, more important
transactions.
Ideally we might drop slow fill requests entirely; for now, just require
that the deposits are actually profitable for a slow fill request to be
submitted.
One side effect of this cleanup is that it allows a lot of the logic to
be flattened. It's now cleaner and simpler to reason about than it was
before.