-
Notifications
You must be signed in to change notification settings - Fork 636
Spelling #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Spelling #528
Changes from all commits
78fa72b
243106d
0cbef52
d3fdef1
bddb73e
604183b
6d55dd8
a1c9436
e187a33
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,7 +92,7 @@ describe('setup-go', () => { | |
| getManifestSpy = jest.spyOn(tc, 'getManifestFromRepo'); | ||
| getAllVersionsSpy = jest.spyOn(im, 'getManifest'); | ||
|
|
||
| // httm | ||
| // httpm | ||
| httpmGetJsonSpy = jest.spyOn(httpm.HttpClient.prototype, 'getJson'); | ||
|
|
||
| // io | ||
|
|
@@ -146,7 +146,7 @@ describe('setup-go', () => { | |
| expect(main.parseGoVersion(goVersionOutput)).toBe('1.16.6'); | ||
| }); | ||
|
|
||
| it('can find 1.9.7 from manifest on osx', async () => { | ||
| it('can find 1.9.7 from manifest on macOS', async () => { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| os.platform = 'darwin'; | ||
| os.arch = 'x64'; | ||
|
|
||
|
|
@@ -544,7 +544,7 @@ describe('setup-go', () => { | |
| expect(added).toBeFalsy(); | ||
| }); | ||
|
|
||
| it('adds bin if dir not exists', async () => { | ||
| it('adds bin if dir does not exist', async () => { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
it might be better to write |
||
| whichSpy.mockImplementation(async () => { | ||
| return '/usr/local/go/bin/go'; | ||
| }); | ||
|
|
@@ -756,7 +756,7 @@ describe('setup-go', () => { | |
| ); | ||
| }); | ||
|
|
||
| it('fallback to dist if version is not found in manifest', async () => { | ||
| it('fall back to dist if version is not found in manifest', async () => { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| os.platform = 'linux'; | ||
| os.arch = 'x64'; | ||
|
|
||
|
|
@@ -793,7 +793,7 @@ describe('setup-go', () => { | |
| expect(cnSpy).toHaveBeenCalledWith(`::add-path::${expPath}${osm.EOL}`); | ||
| }); | ||
|
|
||
| it('fallback to dist if manifest is not available', async () => { | ||
| it('fall back to dist if manifest is not available', async () => { | ||
| os.platform = 'linux'; | ||
| os.arch = 'x64'; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| name: 'Setup Go environment' | ||
| description: 'Setup a Go environment and add it to the PATH' | ||
| description: 'Set up a Go environment and add it to the PATH' | ||
| author: 'GitHub' | ||
| inputs: | ||
| go-version: | ||
|
|
@@ -8,13 +8,13 @@ inputs: | |
| description: 'Path to the go.mod, go.work, .go-version, or .tool-versions file.' | ||
| check-latest: | ||
| description: 'Set this option to true if you want the action to always check for the latest available version that satisfies the version spec' | ||
| default: false | ||
| default: 'false' | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a yaml file and github's action syntax asserts that the The correct thing to do to make the parsers happy is to add quotes around booleans. |
||
| token: | ||
| description: Used to pull Go distributions from go-versions. Since there's a default, this is typically not supplied by the user. When running this action on github.com, the default value is sufficient. When running on GHES, you can pass a personal access token for github.com if you are experiencing rate limiting. | ||
| default: ${{ github.server_url == 'https://github.com' && github.token || '' }} | ||
| cache: | ||
| description: Used to specify whether caching is needed. Set to true, if you'd like to enable caching. | ||
| default: true | ||
| default: 'true' | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a yaml file and github's action syntax asserts that the The correct thing to do to make the parsers happy is to add quotes around booleans. |
||
| cache-dependency-path: | ||
| description: 'Used to specify the path to a dependency file (e.g., go.mod, go.sum)' | ||
| architecture: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments should match code, so this fixes the comment to match the code.