Merged
Conversation
- Introduced handling for the DM database type in GenerateCloudbeaverConnectionParams. - Added a new method, fillDMParams, to configure connection parameters specific to DM. - Updated constant definitions to include DBTypeDM for better database type management.
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
LordofAvernus
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
dm: https://github.com/actiontech/sqle-ee/issues/2637
hive: https://github.com/actiontech/sqle-ee/issues/2581
描述你的变更
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docassgin in @LordofAvernus
Description
为Cloudbeaver连接参数新增Hive支持
新增达梦数据库专用方法fillDMParams
更新常量定义支持Hive及达梦
Diagram Walkthrough
File Walkthrough
cloudbeaver.go
在CloudbeaverUsecase中添加Hive和达梦支持internal/dms/biz/cloudbeaver.go
const.go
更新常量定义与解析支持新数据库类型internal/dms/pkg/constant/const.go